Repository navigation
Conversation
An engine thread owns the installed plan (Planner IR holds Rcs) and receives Remote Write samples from the HTTP server. For each stored summary definition it buffers its Scan metric's samples by tumbling pane. When the watermark (newest sample minus --allowed-lateness-ms) passes a pane's end, it runs the plan's Scan over them (applying label matchers) and the definition's build from its TimeRange input, then stores the output. Panes without samples are stored empty; the first pane seen is skipped because it may be partial; samples for built panes are dropped. A full engine queue answers Remote Write with 503 so senders retry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A PromQL range at T covers (T - range, T], and the executor's series windows follow it. Panes were [start, end), so a sample at a pane boundary was summarized in the next pane. Panes are now (end - width, end]. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 3/5. Base: #819. Next: #821.
Before this PR
Remote Write samples were accepted and dropped.
After this PR
A precompute engine on the engine thread builds stored panes from Remote Write:
Scanselects them, so its label matchers apply.(end − width, end]is built once the watermark (newest sample − allowed lateness) passesend. The build runs the definition's builder compiled from the DAG and stores the summary batch. Panes are open at the start, like PromQL ranges and the executor's windows./api/v1/writereturns 503 when the engine queue is full.Testing
data_plane/tests/precompute.rs(5 tests): the watermark, lateness, label matching, left-open boundaries, eviction.🤖 Generated with Claude Code